Re: [PATCH 3/3] mm/hugetlb: Enforce brace style
From: David Hildenbrand (Red Hat)
Date: Thu Jan 15 2026 - 15:10:44 EST
On 1/15/26 19:14, Joshua Hahn wrote:
Documentation/process/coding-style.rst explicitly notes that if only one
branch of a conditional statement is a single statement, braces should
be used in both branches. Enforce this in mm/hugetlb.c.
No functional change intended.
Signed-off-by: Joshua Hahn <joshua.hahnjy@xxxxxxxxx>
---
[...]
update_and_free_hugetlb_folio(h, folio, false);
return rc;
@@ -2672,11 +2675,13 @@ void restore_reserve_on_error(struct hstate *h, struct vm_area_struct *vma,
* be consumed on a subsequent allocation.
*/
folio_set_hugetlb_restore_reserve(folio);
- } else
+ } else {
/*
* No reservation present, do nothing
*/
vma_end_reservation(h, vma, address);
+
But why the empty line? :)
+ }
}
}
--
Cheers
David