Re: [PATCH] mm: prefer 'unsigned int' over bare 'unsigned' in page_alloc.c
From: Joshua Hahn
Date: Thu Jan 15 2026 - 15:07:57 EST
On Fri, 16 Jan 2026 01:18:45 +0530 Manish Kumar <manish1588@xxxxxxxxx> wrote:
> Change the declaration of 'seq' from 'unsigned' to 'unsigned int'
> to follow kernel coding style. No functional change.
>
> Signed-off-by: Manish Kumar <manish1588@xxxxxxxxx>
Hello Manish, I hope you're doing well!
The patch looks good to me. However, I just have a few comments about the
other patches that you've recently sent out as well.
I think it could be very helpful for reviewers, if you grouped related commits
together (in this case, mm/page_alloc.c cleanups) into a single patchset.
This lets the reviewers view all related commits together, in each others'
contexts.
It would also be super helpful to Cc some of the reviewers / maintainers who
are relevant to the change you are making! scripts/get_maintainer.pl will
give you a good idea of who might be people who are expereinced in the area
and are willing to review the patch.
Thank you for the patchset, have a great day!
Reviewed-by: Joshua Hahn <joshua.hahnjy@xxxxxxxxx>