Re: [PATCH 2/2] spi: aspeed: Add support for non-spi-mem devices

[Mark Brown]

On Thu, Jan 15, 2026 at 11:04:54PM +0800, Chin-Ting Kuo wrote:

> +static int aspeed_spi_user_transfer(struct spi_controller *ctlr,
> +				    struct spi_message *msg)
> +{

I'm not seeing anything here that won't work with transfer_one() rather
than transfer_one_message(), that would reduce open coding so if you can
do it it's preferable.

> +	ctrl_val = chip->ctl_val[ASPEED_SPI_BASE];
> +	ctrl_val &= ~CTRL_IO_MODE_MASK & data->hclk_mask;
> +	ctrl_val |= clk_div;
> +	chip->ctl_val[ASPEED_SPI_BASE] = ctrl_val;

This should fit with the prepare_message() callback.

Attachment: signature.asc
Description: PGP signature