Re: [PATCHv3 02/15] mm: Move MAX_FOLIO_ORDER definition to mmzone.h

From: Kiryl Shutsemau

Date: Thu Jan 15 2026 - 12:27:07 EST


On Thu, Jan 15, 2026 at 05:48:20PM +0100, David Hildenbrand (Red Hat) wrote:
> On 1/15/26 17:35, David Hildenbrand (Red Hat) wrote:
> > On 1/15/26 15:45, Kiryl Shutsemau wrote:
> > > Move MAX_FOLIO_ORDER definition from mm.h to mmzone.h.
> >
> > Why should that belong to mmzone.h ? Semantically doesn't make sense, no?
>
> To clarify, I would have moved it to something more folio-type specific, not
> something buddy/zone specific.
>
> I guess page-flags.h + mm.h are our dumping ground for folio handling. I
> would have moved it to the former.

I moved it next to MAX_PAGE_ORDER definition which seemed to be logical.
Moving MAX_PAGE_ORDER around is much more risky (will likely generate a
lot of build bugs) and outside of the scope of the patchset.

I think wherever they will be moved, it should be moved together.

> Likely we want some folio.h in some distant future.

Sounds like a plan! :P

> Acked-by: David Hildenbrand (Red Hat) <david@xxxxxxxxxx>

Thanks!

--
Kiryl Shutsemau / Kirill A. Shutemov