Re: [PATCH] rust: compile libcore with edition 2024 for 1.87+

[Tamir Duberstein]

On Sun, May 25, 2025 at 5:26 PM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Sat, May 17, 2025 at 10:56 AM Gary Guo <gary@xxxxxxxxxxx> wrote:
> >
> > Rust 1.87 (released on 2025-05-15) compiles core library with edition
> > 2024 instead of 2021 [1]. Ensure that the edition matches libcore's
> > expectation to avoid potential breakage.
> >
> > Cc: stable@xxxxxxxxxxxxxxx # Needed in 6.12.y and later (Rust is pinned in older LTSs).
> > Link: https://github.com/rust-lang/rust/pull/138162 [1]
> > Closes: https://github.com/Rust-for-Linux/linux/issues/1163
> > Signed-off-by: Gary Guo <gary@xxxxxxxxxxx>
>
> Applied to `rust-next` -- thanks everyone!
>
> (I actually applied a couple days ago in advance of Monday's -next,
> which explains the following report)
>
>     [ J3m3 reported in Zulip [2] that the `rust-analyzer` target was
>       broken after this patch -- indeed, we need to avoid `core-cfgs`
>       since those are passed to the `rust-analyzer` target.
>
>       So, instead, I tweaked the patch to create a new `core-edition`
>       variable and explicitly mention the `--edition` flag instead of
>       reusing `core-cfg`s.
>
>       In addition, pass a new argument using this new variable to
>       `generate_rust_analyzer.py` so that we set the right edition there.
>
>       By the way, for future reference: the `filter-out` change is needed
>       for Rust < 1.87, since otherwise we would skip the `--edition=2021`
>       we just added, ending up with no edition flag, and thus the compiler
>       would default to the 2015 one.
>
>       [2] https://rust-for-linux.zulipchat.com/#narrow/channel/291565/topic/x/near/520206547
>
>         - Miguel ]
>
> I also added:
>
>     Reported-by: est31 <est31@xxxxxxxxxxxxxx>
>
> since est31 told Gary in RustWeek, and we discussed the patch there.
>
> @Gary: I hope the changes are OK with you (I can put the
> `generate_rust_analyzer` ones in a different commit if you prefer).
> Thanks!
>
> Cheers,
> Miguel
>

Hey Miguel, regarding the rust-analyzer changes:

I see only core was changed to use `core_edition`, but other sysroot
crates (alloc, std, and proc_macro) still compile with edition 2021
despite all having been updated in the same upstream PR. Was this
intentional, or just an omission?