Re: [PATCH v2 3/3] iio: imu: st_lsm6dsx: Add support for rotation sensor

[Andy Shevchenko]

On Thu, Jan 15, 2026 at 02:51:43PM +0100, Lorenzo Bianconi wrote:
> On Jan 15, Andy Shevchenko wrote:
> > On Thu, Jan 15, 2026 at 02:32:11PM +0100, Lorenzo Bianconi wrote:

...

> > > > +	settings = &sensor->hw->settings->sf_settings;
> > > > +	switch (mask) {
> > > > +	case IIO_CHAN_INFO_SAMP_FREQ: {
> > > > +		u32 odr_mHz;
> > > > +		u8 odr_val;
> > > > +
> > > > +		odr_mHz = val * MILLI + val2 * MILLI / MICRO;
> > > > +		err = st_lsm6dsx_sf_get_odr_val(settings, odr_mHz, &odr_val);
> > > > +		if (err)
> > > > +			return err;
> > > > +
> > > > +		sensor->hwfifo_odr_mHz = odr_mHz;
> > > > +		return 0;
> > > 
> > > break;
> > > 
> > > > +	}
> > > > +	default:
> > > > +		return -EINVAL;
> > > 
> > > break;
> > > 
> > > > +	}
> > > 
> > > return err;
> > 
> > Why?
> 
> I guess it is more clear, but just a Nit, I can live with the current implementation.

At least what you proposed is the opposite to the style that is accepted
in IIO.

-- 
With Best Regards,
Andy Shevchenko