Re: [PATCH v2] clk: st: clkgen-pll: Add cleaup in clkgen_c32_pll_setup()

[Markus Elfring]

> In clkgen_c32_pll_setup(), there exists several leaks if errors ouccers.

                                                                  occur?


> Add iounmap() to free the memory allocated by clkgen_get_register_base().
> Add clk_unregister() and kfree to do the cleaup for clkgen_pll_register().

                                () calls?  cleanup?

Please avoid such typos at more places (including the summary phrase).


> Add a while to do the cleaup for clkgen_odf_register().
> Use distinct variable names for two register calls' return values.

I would find such sentences a bit nicer with a formatting for enumerations.

Regards,
Markus