Re: [PATCH v3 03/10] arm64: dts: qcom: kaanapali: Add TSENS and thermal zones

From: Konrad Dybcio

Date: Thu Jan 15 2026 - 05:23:01 EST


On 1/15/26 8:09 AM, Dmitry Baryshkov wrote:
> On Wed, Jan 14, 2026 at 10:49:05PM -0800, Jingyi Wang wrote:
>> From: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@xxxxxxxxxxxxxxxx>
>>
>> The Kaanapali includes seven TSENS instances, with a total of 55 thermal
>> sensors distributed across various locations on the SoC.
>>
>> The TSENS max/reset threshold is configured to 130°C in the hardware.
>> Enable all TSENS instances, and define the thermal zones with a critical
>> trip at 125°C
>>
>> Signed-off-by: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Jingyi Wang <jingyi.wang@xxxxxxxxxxxxxxxx>
>> ---
>> arch/arm64/boot/dts/qcom/kaanapali.dtsi | 745 ++++++++++++++++++++++++++++++++
>> 1 file changed, 745 insertions(+)
>>
>> @@ -4795,6 +4879,667 @@ pdp_tx: scp-sram-section@100 {
>> };
>> };
>>
>> + thermal-zones {
>> + cpullc-0-0-thermal {
>> + thermal-sensors = <&tsens0 0>;
>> +
>> + trips {
>> + cpullc-0-0-critical {
>> + temperature = <125000>;
>> + hysteresis = <0>;
>> + type = "critical";
>
> I'd really suggest having several "hot" trip points at a temp less than
> 125°C. (And 125°C for critical looks way too critical for me).

LMH and the firmware make sure this never happens, the critical trip
point is a last resort safety mechanism

Konrad