Re: [PATCH v7 2/9] pwm: tiehrpwm: drop _MASK suffix from TBCTL PRDLD field

From: Uwe Kleine-König

Date: Thu Jan 15 2026 - 04:24:02 EST


On Thu, Nov 27, 2025 at 09:36:27PM -0300, Rafael V. Volkmer wrote:
> Rename TIEHRPWM_TBCTL_PRDLD_MASK to TIEHRPWM_TBCTL_PRDLD so the macro
> name describes the PRDLD field itself instead of carrying a _MASK suffix.
>
> Update the single user in ehrpwm_pwm_config() accordingly. The value of
> the bit definition is unchanged.
>
> No functional change.
>
> Signed-off-by: Rafael V. Volkmer <rafael.v.volkmer@xxxxxxxxx>
> ---
> drivers/pwm/pwm-tiehrpwm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c
> index b6020b2210db..f8625394c056 100644
> --- a/drivers/pwm/pwm-tiehrpwm.c
> +++ b/drivers/pwm/pwm-tiehrpwm.c
> @@ -20,7 +20,7 @@
> #define TIEHRPWM_TBCTL 0x00
> #define TIEHRPWM_TBPRD 0x0A
>
> -#define TIEHRPWM_TBCTL_PRDLD_MASK BIT(3)
> +#define TIEHRPWM_TBCTL_PRDLD BIT(3)
> #define TIEHRPWM_TBCTL_PRDLD_SHDW 0
> #define TIEHRPWM_TBCTL_PRDLD_IMDT BIT(3)
> #define TIEHRPWM_TBCTL_CLKDIV_MASK (BIT(12) | BIT(11) | BIT(10) | BIT(9) | \

There are a few more register names ending in _MASK. Would be nice to
change them all consistently.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature