Re: [PATCH v7 4/7] media: platform: amd: isp4 subdev and firmware loading handling added

From: Du, Bin

Date: Thu Jan 15 2026 - 00:56:46 EST




On 1/15/2026 5:08 AM, Mario Limonciello wrote:

Unless the firmware API structs are all __packed in a future firmware update, I
think the memsets should remain.

If you want to be certain of the size of the structs, use BUILD_BUG_ON().


static_assert is another option here too.   I did something like that in drivers/acpi/platform_profile.c to make sure that a structure got updated from new members.

Thank you, Sakari and Mario, for your informative sharing.

--
Regards,
Bin