Re: [PATCH 2/2] Input: ili210x - add support for polling mode

[Marek Vasut]

On 1/13/26 5:41 PM, Frank Li wrote:

[...]

> > @@ -1003,12 +1027,24 @@ static int ili210x_i2c_probe(struct i2c_client *client)
> >   		return error;
> >   	}
> >
> > -	error = devm_request_threaded_irq(dev, client->irq, NULL, ili210x_irq,
> > -					  IRQF_ONESHOT, client->name, priv);
> > -	if (error) {
> > -		dev_err(dev, "Unable to request touchscreen IRQ, err: %d\n",
> > -			error);
> > -		return error;
> > +	input_set_drvdata(input, priv);
> > +
> > +	if (client->irq) {
>
> 0 is validated irq number
>
> https://elixir.bootlin.com/linux/v6.19-rc4/source/drivers/base/platform.c#L284
>
> if (irq < 0)
>
> But it is strange that touch don't connect irq line althougth it works,
> touch generally is wakeup source of system.
Raspi is like that, they poll the touch controllers. It is unfortunate.