Re: [PATCH v14 14/34] PCI/AER: Report CXL or PCIe bus type in AER trace logging

[Jonathan Cameron]

On Wed, 14 Jan 2026 12:20:35 -0600
Terry Bowman <terry.bowman@xxxxxxx> wrote:

> The AER service driver and aer_event tracing currently log 'PCIe Bus Type'
> for all errors. Update the driver and aer_event tracing to log 'CXL Bus
> Type' for CXL device errors.
> 
> This requires that AER can identify and distinguish between PCIe errors and
> CXL errors.
> 
> Introduce boolean 'is_cxl' to 'struct aer_err_info'. Add assignment in
> aer_get_device_error_info() and pci_print_aer().
> 
> Update the aer_event trace routine to accept a bus type string parameter.
> 
> Signed-off-by: Terry Bowman <terry.bowman@xxxxxxx>
> Co-developed-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>

I wonder if it is worth using __print_symbolic() etc and an integer
storage rather than a string for in the tracepoints.
However, not really that important to me as the strings are small anyway
and there is no precedence of this in ras trace events.

Reviewed-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>