Re: [PATCH v3] cxl: Check for invalid addresses returned from translation functions on errors
From: Robert Richter
Date: Wed Jan 14 2026 - 11:44:45 EST
On 14.01.26 09:08:17, Dave Jiang wrote:
> On 1/13/26 10:45 AM, Robert Richter wrote:
> > On 13.01.26 08:51:15, Dave Jiang wrote:
> >> Added user impact statement and fixed up tab formatting reported by checkpatch.
> >
> >>> + pr_err("test random iter %d FAIL hpa=%llu, dpa=%llu reverse_dpa=%llu, pos=%d reverse_pos=%d eiw=%u eig=%u\n",
> >>> + i, hpa, dpa, reverse_dpa, pos, reverse_pos, eiw, eig);
> >
> > Note that my checkpatch does not trigger a tab issue here. How did you
> > test that?
>
> Maybe --strict?
CHECK: Alignment should match open parenthesis
#177: FILE: tools/testing/cxl/test/cxl_translate.c:275:
+ pr_err("test random iter %d FAIL hpa=%llu, dpa=%llu reverse_dpa=%llu, pos=%d reverse_pos=%d eiw=%u eig=%u\n",
+ i, hpa, dpa, reverse_dpa, pos, reverse_pos, eiw, eig);
Got it, thanks.
-Robert