Re: [PATCH v2 3/5] accel/thames: Add IOCTLs for BO creation and mapping

[Markus Elfring]

…
> Buffers belong to a context, which is used by the DSP to switch to the
> page table that mapped the buffers for the user of the job to execute.
> 
> v2:
> - Add thames_accel.h UAPI header (Robert Nelson).

* Please move patch version descriptions behind the marker line.
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc5#n785

* See also once more:
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc5#n94


…
> +++ b/drivers/accel/thames/thames_gem.c
> @@ -0,0 +1,353 @@
…
> +static void thames_free_vaddr(struct thames_device *tdev, struct thames_gem_object *bo)
> +{
…
> +	mutex_lock(&tdev->mm_lock);
> +	drm_mm_remove_node(&bo->mm);
> +	mutex_unlock(&tdev->mm_lock);
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&tdev->mm_lock);”?
https://elixir.bootlin.com/linux/v6.19-rc5/source/include/linux/mutex.h#L253

Regards,
Markus