Re: [PATCH] x86/acpi: Add acpi=spcr to use SPCR-provided default console

[Borislav Petkov]

On Sun, Dec 28, 2025 at 05:22:22PM +0800, Shenghao Yang wrote:
> Commit 0231d00082f6 ("ACPI: SPCR: Make SPCR available to x86")
> made SPCR available as an earlycon option on x86 but did not add
> it as a preferred console to avoid breaking existing setups -

No one has noticed AFAICT since 2018 (this commit's date).

Also:

        /* Do not enable ACPI SPCR console by default */
        acpi_parse_spcr(earlycon_acpi_spcr_enable, false);

Looks nicely conservative to me.

> users have to round trip the dumped console options
> ("SPCR: console: uart,io,0x3f8,115200") back via their
> bootloader.

I don't know what that means.

> Let users opt in so serial console configuration can be made
> automatic.

Why?

Text says:

	[X86] When used with no options the early console is
	determined by the ACPI SPCR table.

But the code doesn't enable the SPCR console by default.

I have no clue what this patch is trying to do.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette