Re: [PATCH v5 1/6] dt-bindings: gpio-mmio: Correct opencores GPIO
From: Geert Uytterhoeven
Date: Wed Jan 14 2026 - 10:36:39 EST
Hi Stafford,
Thanks for your patch!
On Wed, 14 Jan 2026 at 16:14, Stafford Horne <shorne@xxxxxxxxx> wrote:
> In commit f48b5e8bc2e1 ("dt-bindings: gpio-mmio: Add compatible
> string for opencores,gpio") we marked opencores,gpio to be allowed with
> brcm,bcm6345-gpio. This was wrong, opencores,gpio is not hardware
> equivalent to brcm,bcm6345-gpio. It has a different register map and
> is 8-bit vs braodcom which is 32-bit. Change opencores,gpio to be a
broadcom or Broadcom
> separate compatible string for MMIO GPIO.
>
> Fixes: f48b5e8bc2e1 ("dt-bindings: gpio-mmio: Add compatible string for opencores,gpio")
> Signed-off-by: Stafford Horne <shorne@xxxxxxxxx>
> ---
> Since v4:
> - New patch.
> - Rebased old patch and rewrote commit message.
The actual patch LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds