Re: [PATCH 1/3] hwmon: spd5118: Do not fail resume on temporary I2C errors

[Guenter Roeck]

On 1/14/26 05:07, TINSAE TADESSE wrote:
...
> > > Hi Guenter,
> > >
> > > I tested changing the i801 SMBus controller to use
> > > SET_LATE_SYSTEM_SLEEP_PM_OPS() instead of
> > > DEFINE_SIMPLE_DEV_PM_OPS() as a diagnostic experiment. With this
> > > change, spd5118 resume failures (-ENXIO)
> > > still persist, suggesting PM ordering alone is insufficient and other
> > > firmware interactions are involved.
> >
> > How about the problem in the suspend function ? Is that also still seen ?
> >
> > Also, the subject talks about -EIO. Is that still seen ?
> >
> > Either case, can you enable debug logs for the i801 driver ?
> > It should generate log entries when it reports errors.
> >
> > Thanks,
> > Guenter
>
> Hi Guenter,
>
> Thank you for the questions. To clarify:
Please do not drop mailing lists from replies.

> 1) I have not observed any failures in the suspend path. The suspend
> callback completes successfully, and
> I have not seen I2C errors or warnings during suspend at any point.

Sorry, I seem to be missing something.

In that case, what is the point of patch 3/3 of your series which
removes hardware accesses from the suspend function ?

> 2) I have also not observed -EIO in my testing. The error consistently
> reported on resume and subsequent hwmon access is -ENXIO.
> Earlier references to -EIO were based on assumptions rather than
> observed logs, and I should have been clearer about that.

Thanks for the clarification.

Guenter

> I am enabling debug logging for the i801 driver to collect more
> concrete evidence of controller state during resume.