Re: [PATCH 4/5] accel/thames: Add IOCTL for job submission

From: Jani Nikula

Date: Wed Jan 14 2026 - 07:04:55 EST


On Tue, 13 Jan 2026, Tomeu Vizoso <tomeu@xxxxxxxxxxxxxxx> wrote:
> +#include "linux/dev_printk.h"

Random drive-by comment, please use <> instead of "" for include/
headers.

> +#include <drm/drm_file.h>
> +#include <drm/drm_gem.h>
> +#include <drm/drm_print.h>
> +#include <drm/thames_accel.h>
> +#include <linux/platform_device.h>

In general, I think it will make everyone's life easier in the long run
if the include directives are grouped and sorted.

BR,
Jani.


--
Jani Nikula, Intel