Re: [PATCH mm-new v4 2/6] mm: khugepaged: refine scan progress number

[David Hildenbrand (Red Hat)]

On 1/14/26 12:23, David Hildenbrand (Red Hat) wrote:
> >    			mmap_locked = false;
> >    			result = hpage_collapse_scan_file(mm, addr, file, pgoff,
> > -							  cc);
> > +							  NULL, cc);
> >    			fput(file);
> >    		} else {
> >    			result = hpage_collapse_scan_pmd(mm, vma, addr,
> > -							 &mmap_locked, cc);
> > +							 &mmap_locked, NULL, cc);
> >    		}
> >    		if (!mmap_locked)
> >    			*lock_dropped = true;
>
> Seeing the "NULL" tells me that this patch does effectively nothing and
> should likely get squashed into #3 ?

Ah, sorry, I missed the other instanced where you pass something.

From another glimpse, LGTM (although I think the end result might look 
better when both patches are squashed; anyhow, patch #3 fixes these 
instances up)

Acked-by: David Hildenbrand (Red Hat) <david@xxxxxxxxxx>

--
Cheers

David