Re: [PATCH v1 1/1] PM/devfreq: Remove unneeded casting for HZ_PER_KHZ
From: zhenglifeng (A)
Date: Wed Jan 14 2026 - 04:46:41 EST
On 2026/1/14 17:31, Andy Shevchenko wrote:
> HZ_PER_KHZ is defined as UL (unsigned long), no need to repeat that.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/devfreq/devfreq.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 00979f2e0e27..51eb67fba44b 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -146,10 +146,9 @@ void devfreq_get_freq_range(struct devfreq *devfreq,
> DEV_PM_QOS_MIN_FREQUENCY);
> qos_max_freq = dev_pm_qos_read_value(devfreq->dev.parent,
> DEV_PM_QOS_MAX_FREQUENCY);
> - *min_freq = max(*min_freq, (unsigned long)HZ_PER_KHZ * qos_min_freq);
> + *min_freq = max(*min_freq, HZ_PER_KHZ * qos_min_freq);
> if (qos_max_freq != PM_QOS_MAX_FREQUENCY_DEFAULT_VALUE)
> - *max_freq = min(*max_freq,
> - (unsigned long)HZ_PER_KHZ * qos_max_freq);
> + *max_freq = min(*max_freq, HZ_PER_KHZ * qos_max_freq);
>
> /* Apply constraints from OPP interface */
> *max_freq = clamp(*max_freq, devfreq->scaling_min_freq, devfreq->scaling_max_freq);
Make sense. Thanks!
Reviewed-by: Lifeng Zheng <zhenglifeng1@xxxxxxxxxx>