Re: [PATCH v7 4/7] media: platform: amd: isp4 subdev and firmware loading handling added
From: Markus Elfring
Date: Wed Jan 14 2026 - 04:45:32 EST
…
> +++ b/drivers/media/platform/amd/isp4/isp4.c
…
> +void isp4_intr_enable(struct isp4_subdev *isp_subdev, u32 index, bool enable)
> +{
…
> + spin_lock_irq(&isp_subdev->irq_lock);
> + intr_en = isp4hw_rreg(isp_subdev->mmio, ISP_SYS_INT0_EN);
…
> + isp4hw_wreg(isp_subdev->mmio, ISP_SYS_INT0_EN, intr_en);
> + spin_unlock_irq(&isp_subdev->irq_lock);
> +}
…
Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irq)(&isp_subdev->irq_lock);”?
https://elixir.bootlin.com/linux/v6.19-rc5/source/include/linux/spinlock.h#L571-L573
Regards,
Markus