Re: [PATCH v7 09/10] iio: adc: qcom-spmi-iadc: Migrate to devm_spmi_subdevice_alloc_and_add()

[Andy Shevchenko]

On Wed, Jan 14, 2026 at 09:39:56AM +0100, AngeloGioacchino Del Regno wrote:
> Some Qualcomm PMICs integrate an Current ADC device, reachable
> in a specific address range over SPMI.
> 
> Instead of using the parent SPMI device (the main PMIC) as a kind
> of syscon in this driver, register a new SPMI sub-device and
> initialize its own regmap with this sub-device's specific base
> address, retrieved from the devicetree.
> 
> This allows to stop manually adding the register base address to
> every R/W call in this driver, as this can be, and is now, handled
> by the regmap API instead.

> Reviewed-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>
> Tested-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> # on SM8650-QRD

I see these tags, but just again pointing out that max_register in regmap !=
MAX! It's MAX - 1, i.e. the last *accessible* register. So, I find personally
weird the configurations which has 257 registers instead of 256.

This can be easily checked when dumping register contents via debugfs.

Plus the same comments applies here as I gave previously.


-- 
With Best Regards,
Andy Shevchenko