Re: [PATCH v2 1/3] iio: adc: ad9467: include two's complement in default mode

[Tomas Melin]

On 13/01/2026 23:04, Andy Shevchenko wrote:
> On Tue, Jan 13, 2026 at 12:12:47PM +0000, Tomas Melin wrote:
>> All supported drivers currently implicitly use two's complement mode.
>> Make this clear by declaring two's complement in the default
>> output mode. Calibration mode uses offset binary, so change the output
>> mode only when running the calibration or other test mode.
> 
> ...
> 
>>  #include <linux/bitmap.h>
>>  #include <linux/bitops.h>
> 
> Side note: bitmap.h implies and guarantees all bit ops to be provided. No need
> to include bitops.h when bitmap.h is present.
> 
> ...
> 
>>  #define CHIPID_AD9652                   0xC1
>> +#define AD9652_DEF_OUTPUT_MODE		0x01
>>  #define AD9652_REG_VREF_MASK            0xC0
> 
> Another side note: The other definitions around (mistakenly) have been indented
> with spaces. You can see the problem in the diff.
I noticed this too but kept it out of this diff as not directly related.
Thanks for these remarks, keeping in mind for further updates.

BR,
Tomas



>