Re: [PATCH v9 12/13] cxl/region: Factor out code into cxl_region_setup_poison()

From: Alison Schofield

Date: Tue Jan 13 2026 - 22:33:05 EST


On Sat, Jan 10, 2026 at 12:46:57PM +0100, Robert Richter wrote:
> Poison injection setup code is embedded in cxl_region_probe(). For
> improved encapsulation, readability, and maintainability, factor out
> code into function cxl_region_setup_poison().
>
> This patch is a prerequisit to disable poison injection for Normalized
> Addressing.

I prefer we be clearer about intent. Poison injection altogether is not
being disabled, only by region offset.

Replace this:
> This patch is a prerequisit to disable poison injection for Normalized
> Addressing.

With this:
This patch is a prerequisite to disable poison by region offset for
Normalized Addressing.

With that,
Reviewed-by: Alison Schofield <alison.schofield@xxxxxxxxx>