Re: [PATCH 04/31] nova-core: factor .fwsignature* selection into a new get_gsp_sigs_section()

[John Hubbard]

On 1/13/26 5:33 AM, Gary Guo wrote:
> On Wed Dec 3, 2025 at 5:58 AM GMT, John Hubbard wrote:
...
>> -        let sigs_section = match chipset.arch() {
>> -            Architecture::Ampere => ".fwsignature_ga10x",
>> -            Architecture::Hopper => ".fwsignature_gh10x",
>> -            Architecture::Ada => ".fwsignature_ad10x",
>> +    fn get_gsp_sigs_section(chipset: Chipset) -> Result<&'static str> {
> 
> I would just return `Option` here, and have
> 
>     let sigs_section = Self::get_gsp_sigs_section(chipset).ok_or(ENOTSUPP)?;
> 
> similar to the ELF line aboe it.

Nice, I'll do that.

> 
> The code looks correct to me regardless if you make the change.
> 
> Reviewed-by: Gary Guo <gary@xxxxxxxxxxx>

Thanks for the review (here and elsewhere)!


thanks,
-- 
John Hubbard