Re: [PATCH v3] staging: fbtft: Change udelay() to fsleep()
From: Andy Shevchenko
Date: Tue Jan 13 2026 - 17:34:20 EST
On Wed, Jan 14, 2026 at 12:17 AM Gideon Adjei <gideonadjei.dev@xxxxxxxxx> wrote:
>
> Replace udelay() calls >= 100us with fsleep() to avoid busy-waiting.
>
> The delays are used in init_display() callbacks. These callbacks are
> invoked by fbtft_probe_common() during the driver's probe path. The
> probe path runs in process context which already uses sleeping APIs.
> This makes fsleep() safe to use in these situations.
You forgot to add a changelog...
> Signed-off-by: Gideon Adjei <gideonadjei.dev@xxxxxxxxx>
> ---
...somewhere here.
No need to send v4 because of this, just reply with the changelogs for
v1->v2 and v2->v3.
Also note, it's assumed that even for such a simple patch the time
between versions is at least 24h.
> drivers/staging/fbtft/fb_tinylcd.c | 2 +-
> drivers/staging/fbtft/fb_upd161704.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
--
With Best Regards,
Andy Shevchenko