Re: 答复: 答复: 答复: [外部邮件] Re: [PATCH] x86/mce: Fix timer interval adjustment after logging a MCE event
From: Nikolay Borisov
Date: Tue Jan 13 2026 - 14:51:51 EST
On 13.01.26 г. 21:44 ч., Borislav Petkov wrote:
On Tue, Jan 13, 2026 at 09:37:13PM +0200, Nikolay Borisov wrote:
Yes, and why is Li's approach not working, i.e if mc_poll_banks() returns a
value signalling "i found an MCE" we halve, otherwise we double it?
It might be "working" but I don't like that "bool logged" thing and
marshalling it back'n'forth. This should be waaay simpler.
That's certainly doable, but why should the interval setting be coupled to
the initial notifier and not to mc_poll_banks?
What's the difference who notifies the timer? The banks polling will call the
notifier if it finds an error to log.
But before we do any of that, we need to figure out what commit broke this so
that we fix stable.
Thx.
grepping around points to your 011d82611172 ("RAS: Add a Corrected Errors Collector"). Because looking at the commit log of my 6447828875b7 ("x86/mce/inject: Remove call to mce_notify_irq()") I mention that mce_need_notify got introduced in your commit and it was called "notify_user" before that. Before your commit in mce_log there was an explicit set_bit(mce_need_notify) call .