Re: [RFC PATCH v2] genirq/cpuhotpug: notify of irq affinity change for offlined cpu.

[imran . f . khan]

Hello Thomas,
Thanks a lot for reviewing this patch.

On 13/1/2026 5:24 pm, Thomas Gleixner wrote:
> On Tue, Jan 13 2026 at 10:24, Thomas Gleixner wrote:
>> On Sat, Jan 03 2026 at 00:53, Imran Khan wrote:
>>> +			if (affinity_broken && desc->affinity_notify) {
>>> +				kref_get(&desc->affinity_notify->kref);
>>> +				if (!schedule_work(&desc->affinity_notify->work)) {
>>> +					/* Work was already scheduled, drop our extra ref */
>>> +					kref_put(&desc->affinity_notify->kref,
>>> +					desc->affinity_notify->release);
>>> +				}
>>> +			}
>>
>> No, we are not doing random copy&pasta.
>>
>> Split out the functionality into a function and use it both here and in
>> irq_set_affinity_locked().
> 
> And while at it you might fix the typos in subject and change log.

I have addressed your review comments and have sent a new (v3) version
of this patch at [1].
Could you please have a look and let me know if it looks okay now.

Thanks,
Imran

[1]: https://lore.kernel.org/all/20260113143727.1041265-1-imran.f.khan@xxxxxxxxxx/