Re: [PATCH 06/31] gpu: nova-core: apply the one "use" item per line policy to commands.rs
From: Gary Guo
Date: Tue Jan 13 2026 - 08:36:03 EST
On Wed Dec 3, 2025 at 5:58 AM GMT, John Hubbard wrote:
> As per [1], we need one "use" item per line, in order to reduce merge
> conflicts. Furthermore, we need a trailing ", //" in order to tell
> rustfmt(1) to leave it alone.
>
> This does that for commands.rs, which is the only file in nova-core that
> has any remaining instances of the old style.
>
> [1] https://docs.kernel.org/rust/coding-guidelines.html#imports
>
> Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx>
Reviewed-by: Gary Guo <gary@xxxxxxxxxxx>
> ---
> drivers/gpu/nova-core/gsp/fw/commands.rs | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)