Re: [PATCH v2] sched/clock: Avoid false sharing for sched_clock_irqtime

From: K Prateek Nayak

Date: Tue Jan 13 2026 - 05:14:47 EST


Hello Peter,

On 1/13/2026 3:37 PM, Peter Zijlstra wrote:
> On Tue, Jan 13, 2026 at 03:48:07PM +0800, Wangyang Guo wrote:
>> Read-mostly sched_clock_irqtime may share the same cacheline with
>> frequently updated nohz struct. Mark it as __read_mostly to avoid
>> false sharing issue.
>>
>
> Is there a reason that thing can't be a static_key or so?

Yes, the exact case is stated in commit b9f2b29b9494
("sched: Don't define sched_clock_irqtime as static key")
https://lore.kernel.org/lkml/173961695743.10177.17683780278419896262.tip-bot2@tip-bot2/

--
Thanks and Regards,
Prateek