Re: [PATCH v9 27/30] KVM: arm64: selftests: Remove spurious check for single bit safe values

From: Ben Horgan

Date: Tue Jan 13 2026 - 05:05:26 EST


Hi Mark,

On 12/23/25 01:21, Mark Brown wrote:
> get_safe_value() currently asserts that bitfields it is generating a safe
> value for must be more than one bit wide but in actual fact it should
> always be possible to generate a safe value to write to a bitfield even if
> it is just the current value and the function correctly handles that.
> Remove the assert.
>
> Fixes: bf09ee918053e ("KVM: arm64: selftests: Remove ARM64_FEATURE_FIELD_BITS and its last user")
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>

Yes, this assert was unneeded.

Reviewed-by: Ben Horgan <ben.horgan@xxxxxxx>

Thanks,

Ben