Re: [net-next,v3,11/13] octeontx2-pf: cn20k: Add TC rules support

[Ratheesh Kannoth]

On 2026-01-11 at 04:29:36, Jakub Kicinski (kuba@xxxxxxxxxx) wrote:
> > +		entry = node->entry;
> > +		goto free_mcam_entry;
> > +	}
>
> [ ... ]
>
> > +free_mcam_entry:
> > +	if (cn20k_tc_free_mcam_entry(nic, entry))
> > +		netdev_err(nic->netdev, "Freeing entry %d to AF failed\n",
> > +			   first->entry);
>                            ^^^^^^^^^^^^
>
> Should this error message print 'entry' instead of 'first->entry'? When
> the code takes the "not shiftable" path, it sets entry = node->entry and
> jumps to free_mcam_entry. At that point, first->entry may be different
> from the entry value that was actually passed to cn20k_tc_free_mcam_entry().
>
ACK
> > +}