Re: [PATCH] sched/deadline: Fix server stopping with runnable tasks
From: Juri Lelli
Date: Tue Jan 13 2026 - 04:51:05 EST
On 13/01/26 10:42, Gabriele Monaco wrote:
> On Tue, 2026-01-13 at 10:37 +0100, Peter Zijlstra wrote:
> > > static void update_curr_dl_se(struct rq *rq, struct sched_dl_entity *dl_se,
> > > s64 delta_exec)
> > > {
> > > - bool idle = rq->curr == rq->idle;
> > > + bool idle = rq->curr == rq->idle && !rq->nr_running && !rq-
> > > >ttwu_pending;
> >
> > This is idle_cpu(), perhaps we can lift that thing into sched.h or so.
> >
>
> Yeah, that's what I meant by quick and dirty.. I have idle_cpu() on the model
> side (and have them matching simplifies a lot of things).
>
> I just wasn't sure if we wanted a function call in there. But we can probably do
> something nicer without it too.
Thanks for the patch (looks sensible to me too) and nice catch from the
model!