Re: [PATCH] mm/khugepaged: make khugepaged_collapse_control static

[Ben Dooks]

On 12/01/2026 16:33, Lorenzo Stoakes wrote:
> On Mon, Jan 12, 2026 at 04:18:20PM +0000, Ben Dooks wrote:
> > Make khugepaged_collapse_control as it is not exported.
> > Fixes the following sparse warning:
> >
> > mm/khugepaged.c:829:25: warning: symbol 'khugepaged_collapse_control' was not declared. Should it be static?
>
> Thanks for the patch, but sorry to say that this has already been addressed in
> [0].
>
> [0]: https://lore.kernel.org/all/20251224111351.41042-14-shivankg@xxxxxxx/
>
> > Fixes: 34d6b470ab9cf ("mm/khugepaged: add struct collapse_control")
>
> (Small note: for something like this that isn't fixing an actual bug we don't
> use a fixes like this).

Is this a subsystem preference because I was told I needed it for other
patches.

--
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html