Re: [RFC PATCH 01/77] checks: Use consistent type for strspn() returned value
From: Herve Codina
Date: Tue Jan 13 2026 - 03:02:28 EST
Hi David,
On Tue, 13 Jan 2026 15:42:31 +1100
David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, Jan 13, 2026 at 02:08:54PM +1100, David Gibson wrote:
> > On Mon, Jan 12, 2026 at 03:18:51PM +0100, Herve Codina wrote:
> > > strspn() returns a size_t value.
> > >
> > > The function is called in several places and in all places this value is
> > > stored in a size_t variable except in check_node_name_chars_strict().
> > >
> > > Fix the variable type used in check_node_name_chars_strict().
> > >
> > > Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx>
> >
> > This one makes sense regardless of the rest, so, merged.
>
> I spoke too soon. This causes a compile error:
>
> https://github.com/dgibson/dtc/actions/runs/20944813954/job/60185662154#step:5:130
>
> For some reason it's only showing on the make build, not meson. I
> guess there must be a mismatch in which warnings are enabled.
I used only meson and so I missed the signed/unsigned comparison warning.
I will remove this signed/unsigned warning in the next iteration.
Best regards,
Hervé