Re: [PATCH 3/6] x86/microcode: Refactor platform ID enumeration into a helper

[Andy Shevchenko]

On Tue, Jan 20, 2026 at 08:06:41AM -0800, Dave Hansen wrote:
> On 1/19/26 19:07, Chao Gao wrote:

...

> >> +#include <asm/cpu.h>
> >> #include <asm/msr.h>
> >> +#include <asm/intel-family.h>
> > nit: You may want to sort the header files alphabetically.
> 
> I was probably going for christmas tree here or something. But,
> seriously, I don't think we've written down any guidance on header
> ordering for tip or in the tree in general.
> 
> It's still kinda the wild west, I think.

It was unclear why you put these two new headers in such an order.
Because it feels like you wanted something like alphabetical, but
something went differently. For the xmas tree I would expect them
still go together

#include <asm/msr.h>
#include <asm/cpu.h>
#include <asm/intel-family.h>

But personally I'm with Chao Gao, the alphabetical is easier to maintain
as it's natural order that many people got for many years starting from
kindergarten times.

-- 
With Best Regards,
Andy Shevchenko