Re: [PATCH 25/37] cifs: SMB1 split: Split SMB1 protocol defs into smb1pdu.h

[ChenXiaoSong]

FILE_BASIC_INFO (and possibly other definitions) is also used in 
client/smb2inode.c, and it is defined in MS-FSCC 2.4.7, so perhaps we 
should move these definitions into a new header file client/fscc.h.

Of course, for FILE_BASIC_INFO, smb/server/ has smb2_file_basic_info in 
smb/server, so we could move them into common/fscc.h.

Thanks,
ChenXiaoSong <chenxiaosong@xxxxxxxxxx>

On 12/23/25 06:29, David Howells wrote:
> --- a/fs/smb/client/cifsfs.c
> +++ b/fs/smb/client/cifsfs.c
> -typedef struct {
> -	__le64 CreationTime;
> -	__le64 LastAccessTime;
> -	__le64 LastWriteTime;
> -	__le64 ChangeTime;
> -	__le32 Attributes;
> -	__u32 Pad;
> -} __packed FILE_BASIC_INFO;	/* size info, level 0x101 */
> -
> --- /dev/null
> +++ b/fs/smb/client/smb1pdu.h
> +typedef struct {
> +	__le64 CreationTime;
> +	__le64 LastAccessTime;
> +	__le64 LastWriteTime;
> +	__le64 ChangeTime;
> +	__le32 Attributes;
> +	__u32 Pad;
> +} __packed FILE_BASIC_INFO;	/* size info, level 0x101 */
> +