Re: [PATCH 0/9] gpib: Unify *allocate_private
From: Dan Carpenter
Date: Mon Jan 19 2026 - 02:34:57 EST
On Tue, Jan 13, 2026 at 07:08:37PM +0000, Dominik Karol Piątkowski wrote:
> Recently, gpib driver got out of staging area. There is still a bit of work that
> can be done to improve it.
>
> Return values for *allocate_private functions as well as calling code in
> gpib driver are all over the place. Unify them by returning -errno if
> something fails, zero otherwise. Use the returned value as early return
> value in case of error.
>
> Untouched gpib files already use the proposed convention.
>
> Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@xxxxxxxxxxxxxx>
I don't see the point of the allocate_private() functions. Why not
just open code it?
regards,
dan carpenter