Re: [PATCH v2 19/21] x86/virt/tdx: Establish contexts for the new TDX Module

From: Chao Gao

Date: Mon Jan 19 2026 - 03:49:57 EST


>> +int tdx_module_run_update(void)
>> +{
>> + struct tdx_module_args args = {};
>> + int ret;> +
>> + ret = seamcall(TDH_SYS_UPDATE, &args);
>
>Since it's a seamcall error, shouldn't it be u64?

Good catch. I will use seamcall_prerr(), which returns an int.

>
>> + if (ret) {
>> + tdx_module_status = TDX_MODULE_ERROR;
>> + pr_info("module update failed: %d\n", ret);
>
>pr_info -> pr_err?

Yes.