Re: [PATCH V5 0/2] mm/khugepaged: fix dirty page handling for MADV_COLLAPSE

[David Hildenbrand (Red Hat)]

On 1/19/26 06:07, Garg, Shivank wrote:
> On 1/19/2026 1:52 AM, Andrew Morton wrote:
> > Please tolerate a little whining about the timeliess here.  We're at
> > -rc6, v4 was added to mm.git over a month ago, had quite a lot of
> > review, this is very close to being moved into the mm-stable branch and now
> > we get v5.  Argh.
> I sincerely apologize for this.
>
> I had this doubt on sending an incremental patch or V5:
> https://lore.kernel.org/linux-mm/7a42515f-ae57-4f4d-831c-87689930a797@xxxxxxx
>
>
> > > V5:
> > > - In patch 2/2, Simplify dirty writeback retry logic (David)
> > Are you sure this is the only change?  It looks like a lot for a
> > simplification and I'm wondering if we should retain the v4 series and
> > defer a simplification for separate consideration during the next
> > cycle.
>
> Yes, patch 1/2 is unchanged and patch 2/2 is the only change.
> The diff looks larger due to code movement but logic is actually simpler now.
>
> I completely understand if you prefer to keep V4 and defer this
> refactoring. I'm sorry for creating this late-cycle churn. Please let me
> know what you'd prefer and I'll follow your guidance.

There is no reason to rush any of this. :)

Review was not over and due to multiple factors my review on v4 came in 
later than I wanted.

Andrew, if you prefer, I can start sending as a reply to every patch set 
that I want to review so you are aware that it is on my review backlog.

Unfortunately we can't have nice things (sub-maintainer acks).

--
Cheers

David