Re: [PATCH v2 2/2] arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC

[Neeraj Soni]

Hi,

On 1/16/2026 12:49 PM, Krzysztof Kozlowski wrote:
> On 16/01/2026 06:59, Neeraj Soni wrote:
>>> Why this became uppercase?
>> Thnaks for pointing out. I will fix this next patch.
>>>
>>>> +			compatible = "qcom,sc7280-inline-crypto-engine",
>>>> +				     "qcom,inline-crypto-engine";
>>>> +			reg = <0x0 0x007C8000 0x0 0x18000>;
>>>
>>> And this? there is no uppercase at all, so maybye you copied it from
>>> downstream, but that's not right approach - do not use downstream code.
>>>
>> Yes it was copied but i missed to align with upstream. Thanks for pointing out. This will be fixed in next patch.
> 
> And that's the problem. You must NEVER COPY downstream DTS. We repeat it
> and repeat it...
> 
Sure and i apologize for missing this. I will be fixing this in next patch and will ensure this is not repeated
in any future posts.

> Best regards,
> Krzysztof
>