Re: [PATCH v2 0/2] Enable Inline crypto engine for kodiak

[Neeraj Soni]

Hi,

On 1/14/2026 9:48 PM, Rob Herring wrote:
> 
> On Wed, 14 Jan 2026 15:18:46 +0530, Neeraj Soni wrote:
>> Document Inline Crypto Engine (ICE) handle for SDHC and add its device-tree
>> node to enable it for kodiak.
>>
>> How this patch was tested:
>> - export ARCH=arm64
>> - export CROSS_COMPILE=aarch64-linux-gnu-
>> - make menuconfig
>> - make defconifg
>> - make DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/sdhci-msm.yaml dt_binding_check
>> - make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y dtbs
>>
>> ---
>> Changes in v2:
>> - Removed the "if: required:" description for "qcom,ice" dt-binding
>>   as the ICE node is optional.
>> - Corrected the ICE dt node entry according to the dt-binding description.
>> - Added test details.
>>
>> Changes in v1:
>> - Updated the dt-binding for ICE node.
>> - Added the dt node for ICE for kodiak.
>>
>> Neeraj Soni (2):
>>   dt-bindings: mmc: sdhci-msm: Add ICE phandle
>>   arm64: dts: qcom: kodiak: enable the inline crypto engine for SDHC
>>
>>  Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 4 ++++
>>  arch/arm64/boot/dts/qcom/kodiak.dtsi                 | 9 +++++++++
>>  2 files changed, 13 insertions(+)
>>
>> --
>> 2.34.1
>>
>>
>>
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> This patch series was applied (using b4) to base:
>  Base: attempting to guess base-commit...
>  Base: tags/v6.19-rc1-102-g3af51501e2b8 (exact match)
>  Base: tags/v6.19-rc1-102-g3af51501e2b8 (use --merge-base to override)
> 
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
> 
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20260114094848.3790487-1-neeraj.soni@xxxxxxxxxxxxxxxx:
> 
> arch/arm64/boot/dts/qcom/sm7325-nothing-spacewar.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-crd-pro.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: pmic@2 (qcom,pm8350c): pwm:nvmem: [[386, 387]] is too short
> 	from schema $id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: pwm (qcom,pm8350c-pwm): nvmem: [[386, 387]] is too short
> 	from schema $id: http://devicetree.org/schemas/leds/leds-qcom-lpg.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/qcm6490-idp.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/qcm6490-particle-tachyon.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-idp.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-lte.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-idp2.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-lte.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme-lte.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-zombie-nvme.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/qcs6490-thundercomm-rubikpi3.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1-lte.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/qcs6490-radxa-dragon-q6a.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dtb: soc@0 (simple-bus): crypto@7C8000: 'ranges' is a required property
> 	from schema $id: http://devicetree.org/schemas/simple-bus.yaml
> 
The crypto node i added is not a "bus" node but a leaf node for Inline Crypto Engine (ICE). There are no props like "compatible = "simple-bus"" or "#address-cells" and "#size-cells" 
added in the ICE dt which indicates it is bus device so why the tool expects "ranges" prop? Adding "ranges" as a property in ICE node will be wrong since it is not a "bus" device.
> 
> 
> 
> 
Regards
Neeraj