Re: [PATCH 10/11] perf/amd/ibs: Enable streaming store filter

[Ravi Bangoria]

Hi Dapeng,

>> @@ -416,6 +425,15 @@ static int perf_ibs_init(struct perf_event *event)
>>  		hwc->extra_reg.config |= fetchlat << 1;
>>  	}
>>  
>> +	if (perf_ibs_strmst_event(perf_ibs, event)) {
>> +		u64 strmst = event->attr.config1 & IBS_OP_CONFIG1_STRMST_MASK;
>> +
>> +		strmst >>= 12;
> 
> The right shift can be directly merged into previous sentence, and better
> define some macro instead of use these magic numbers.

Ack.

Thanks for the review,
Ravi