Re: [PATCH v2] Makefile: Remove the product of pin_init cleanly in mrporper

[Chen Miao]

在 2026/1/19 06:30, Miguel Ojeda 写道:
> On Fri, Oct 31, 2025 at 3:32 AM chenmiao <chenmiao@xxxxxxxxxxxxx> wrote:
>> When I enabled Rust compilation, I wanted to clean up its output, so I
>> used make clean and make mrproper. However, I was still able to find that
>> libpin_init_internal.so in the rust directory was not deleted, while
>> all other corresponding outputs were cleared.
>>
>> Dongliang Mu <dzm91@xxxxxxxxxxx>
> This line seems broken. Was this meant to be a Reviewed-by, like in v1?
Yes, it should be `Reviewed-by`.
>> Signed-off-by: chenmiao <chenmiao@xxxxxxxxxxxxx>
> I think in another patch/thread you mentioned this should be "Chen Miao", right?
Yes, Please modify this to Chen Miao.
>
> No need for a new patch, I can fix both on apply if you agree.
>
> Adding the relevant people to Cc (pin-init, Kbuild and Rust). And
> Tamir for the `.dylib` side.
>
> Also, I guess we could backport this:
>
> Fixes: d7659acca7a3 ("rust: add pin-init crate build infrastructure")
> Cc: stable@xxxxxxxxxxxxxxx
>
> Cheers,
> Miguel

If it’s convenient for you, I think your proposal sounds great and I agree.

Thanks for the review.

Regards,

Chen Miao