Re: [PATCH v2 02/10] gpu: nova-core: gsp: remove unnecessary Display impls

From: Gary Guo

Date: Mon Jan 19 2026 - 10:41:36 EST


On Tue Dec 16, 2025 at 4:27 AM GMT, Alexandre Courbot wrote:
> We only ever display these in debug context, for which the automatically
> derived `Debug` impls work just fine - so use them and remove these
> boilerplate-looking implementations.
>
> Reviewed-by: Lyude Paul <lyude@xxxxxxxxxx>
> Reviewed-by: Alistair Popple <apopple@xxxxxxxxxx>
> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>

Reviewed-by: Gary Guo <gary@xxxxxxxxxxx>

> ---
> drivers/gpu/nova-core/gsp/cmdq.rs | 2 +-
> drivers/gpu/nova-core/gsp/fw.rs | 54 ---------------------------------------
> 2 files changed, 1 insertion(+), 55 deletions(-)