Re: [PATCH v2 03/10] gpu: nova-core: gsp: simplify sequencer opcode parsing
From: Gary Guo
Date: Mon Jan 19 2026 - 11:11:43 EST
On Tue Dec 16, 2025 at 4:27 AM GMT, Alexandre Courbot wrote:
> The opcodes are already the right type in the C union, so we can use
> them directly instead of converting them to a byte stream and back again
> using `FromBytes`.
>
> Reviewed-by: Lyude Paul <lyude@xxxxxxxxxx>
> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
Reviewed-by: Gary Guo <gary@xxxxxxxxxxx>
> ---
> drivers/gpu/nova-core/gsp/fw.rs | 40 +++++-----------------------------------
> 1 file changed, 5 insertions(+), 35 deletions(-)