Re: [PATCH v2 2/4] dma-buf: Document revoke semantics
From: Jason Gunthorpe
Date: Mon Jan 19 2026 - 11:46:21 EST
On Sun, Jan 18, 2026 at 03:29:02PM +0100, Thomas Hellström wrote:
> Why would the importer want to verify the exporter's support for
> revocation? If the exporter doesn't support it, the only consequence
> would be that invalidate_mappings() would never be called, and that
> dma_buf_pin() is a NOP. Besides, dma_buf_pin() would not return an
> error if the exporter doesn't implement the pin() callback?
I think the comment and commit message should be clarified that
dma_buf_attachment_is_revoke() is called by the exporter.
The purpose is for the exporter that wants to call move_notify() on a
pinned DMABUF to determine if the importer is going to support it.
Jason