Re: [PATCH v3 3/3] spi: xilinx: use device property accessors.

From: Mark Brown

Date: Mon Jan 19 2026 - 12:32:18 EST


On Mon, Jan 19, 2026 at 09:15:40AM -0800, Abdurrahman Hussain wrote:
> > On Jan 19, 2026, at 8:50 AM, Mark Brown <broonie@xxxxxxxxxx> wrote:
> > On Mon, Jan 19, 2026 at 08:47:17AM -0800, Abdurrahman Hussain wrote:

> >>> Are these bindings appropraite for ACPI systems?

> >> Yes, the Xilinx IP blocks are memory mapped and work exactly the same on ACPI as they do on DT.

> > That does not answer the question at all. Is it appropriate to
> > configure an ACPI system in this way?

> I am not sure I understood your question. What do you mean by “appropriate”?
> This is following the same guidelines as outlined in
> https://www.kernel.org/doc/html/v6.7/firmware-guide/acpi/enumeration.html

You are just bindly making the DT properties available as _DSD
properties on ACPI systems, ACPI is a completely different firmware
interface with it's own idioms. Does this interface make any sense on
ACPI?

Attachment: signature.asc
Description: PGP signature