Re: [PATCH net] idpf: Fix data race in idpf_net_dim
From: Eric Dumazet
Date: Mon Jan 19 2026 - 12:59:58 EST
On Mon, Jan 19, 2026 at 5:28 PM David Yang <mmyangfl@xxxxxxxxx> wrote:
>
> In idpf_net_dim(), some statistics protected by u64_stats_sync, are read
> and accumulated in ignorance of possible u64_stats_fetch_retry() events.
> The correct way to copy statistics is already illustrated by
> idpf_add_queue_stats(). Fix this by reading them into temporary variables
> first.
>
> Fixes: c2d548cad150 ("idpf: add TX splitq napi poll support")
> Fixes: 3a8845af66ed ("idpf: add RX splitq napi poll support")
> Signed-off-by: David Yang <mmyangfl@xxxxxxxxx>
> ---
Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>
It seems ovs_vport_get_upcall_stats() has a similar bug, are you
interested to fix it as well ?
Thanks !