Re: [PATCH 2/6] x86/cpu: Add missing #include

From: Dave Hansen

Date: Mon Jan 19 2026 - 19:26:34 EST


On 1/19/26 11:50, Dave Hansen wrote:
> diff -puN arch/x86/include/asm/intel-family.h~fam-missing-include arch/x86/include/asm/intel-family.h
> --- a/arch/x86/include/asm/intel-family.h~fam-missing-include 2026-01-19 11:38:08.254872476 -0800
> +++ b/arch/x86/include/asm/intel-family.h 2026-01-19 11:38:08.257872590 -0800
> @@ -2,6 +2,8 @@
> #ifndef _ASM_X86_INTEL_FAMILY_H
> #define _ASM_X86_INTEL_FAMILY_H
>
> +#include <asm/vfm.h>
> +
> /*
> * "Big Core" Processors (Branded as Core, Xeon, etc...)
> *

In a private 0-day mail, it told me:

> On 1/19/26 15:33, kernel test robot wrote:
> ...> config: parisc-randconfig-001-20260120...> In file included from include/linux/peci-cpu.h:33,
>> from drivers/peci/device.c:6:
>>>> include/linux/../../arch/x86/include/asm/intel-family.h:5:10: fatal error: asm/vfm.h: No such file or directory
>> #include <asm/vfm.h>
>> ^~~~~~~~~~~
>> compilation terminated.
>>
>>
>> vim +5 include/linux/../../arch/x86/include/asm/intel-family.h

I made a change to intel-family.h and it broke a parisc config. All
thanks to the PECI header that does:

#include "../../arch/x86/include/asm/intel-family.h"

in arch-independent code. I'll fix this up in a v2 but reviews on v1 are
still appreciated.